Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access to bytes::Bytes from protobuf::Chars #721

Closed
wants to merge 3 commits into from

Conversation

SamHDev
Copy link

@SamHDev SamHDev commented Apr 20, 2024

Added AsRef<bytes::Bytes> to protobuf::Chars to allow access to inner type.

As per #720

There is an issue of this being a breaking change to anyone who uses the Deref -> AsRef<_> impl.
Perhaps a 'getter' function might be a better way to go around this to keep the API compatible?

@SamHDev SamHDev closed this Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant